Add deduction guides for blocked_nd_range #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarutyun
reviewed
Oct 8, 2025
source/elements/oneTBB/source/algorithms/blocked_ranges/blocked_nd_range_cls.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/algorithms/blocked_ranges/blocked_nd_range_cls.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Ruslan Arutyunyan <[email protected]>
Co-authored-by: Ruslan Arutyunyan <[email protected]>
…m/kboyarinov/oneAPI-spec into blocked_nd_range-deduction-guides
vossmjp
reviewed
Oct 29, 2025
| blocked_nd_range(const Value (&)[N], typename blocked_nd_range<Value, N>::size_type = 1) | ||
| -> blocked_nd_range<Value, N>; | ||
| template </*see-below*/> |
There was a problem hiding this comment.
I prefer keeping the previous:
template <typename Value>
blocked_nd_range(/*a set of braced-init-lists of Value objects*/)
-> blocked_nd_range<Value, /*number of braced-init-lists*/>;
And then the detailed description provides the two options for how to do that. What's currently here seems even less clear.
There was a problem hiding this comment.
You might add the "see-below" comment in addition, like blocked_nd_range(/*a set of braced-init-lists of Value objects (see-below)*/)
There was a problem hiding this comment.
Applied the combined approach with the comment below.
akukanov
reviewed
Oct 29, 2025
source/elements/oneTBB/source/algorithms/blocked_ranges/blocked_nd_range_cls.rst
Outdated
Show resolved
Hide resolved
vossmjp
approved these changes
Oct 31, 2025
akukanov
reviewed
Oct 31, 2025
source/elements/oneTBB/source/algorithms/blocked_ranges/blocked_nd_range_cls.rst
Show resolved
Hide resolved
source/elements/oneTBB/source/algorithms/blocked_ranges/blocked_nd_range_cls.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/algorithms/blocked_ranges/blocked_nd_range_cls.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/algorithms/blocked_ranges/blocked_nd_range_cls.rst
Outdated
Show resolved
Hide resolved
source/elements/oneTBB/source/algorithms/blocked_ranges/blocked_nd_range_cls.rst
Outdated
Show resolved
Hide resolved
…d_nd_range_cls.rst Co-authored-by: Alexey Kukanov <[email protected]>
…d_nd_range_cls.rst Co-authored-by: Alexey Kukanov <[email protected]>
…d_nd_range_cls.rst Co-authored-by: Alexey Kukanov <[email protected]>
…d_nd_range_cls.rst Co-authored-by: Alexey Kukanov <[email protected]>
…d_nd_range_cls.rst Co-authored-by: Alexey Kukanov <[email protected]>
akukanov
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.